Handle OpenID connect errors more clearly #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, whenever the OpenID connect login flow encounters an error, the user will be redirected to the login again. The error message is included in the response (as base64-encoded JSON in the
errorquery parameter), but is ignored. This can make it very opaque why the user is redirected to the login again (Insufficient permissions? Not allowed to authenticate? No matching role? Broken OpenID connect configuration?)It would be nice that, rather than forwarding, the error would be shown to the user in a window, with buttons "go back" and "log in" (depending on the context).
This PR does alert the error message in a very rudimentary fashion, but it needs to be more polished.