Removed ConfigureAwait from Middleware since user-context is relevant (…

…#1047)

examples/ASP.NET Core 3/ASP.NET Core 3 - VS2019/Controllers/ApiController.cs

@@ -24,7 +24,7 @@ public async Task<ActionResult> TestLog([FromBody]string request)
         {
             try
             {
-                await Task.Delay(5).ConfigureAwait(false);
+                await Task.Delay(5);
                 throw new ApplicationException("Test log message");
             }
             catch (Exception ex)

src/NLog.Web.AspNetCore/NLogBufferingTargetWrapperMiddleware.cs

@@ -45,7 +45,7 @@ public async Task Invoke(HttpContext context)
                 AspNetBufferingTargetWrapper.OnBeginRequest(context);
 
                 // Execute the next class in the HTTP pipeline, this can be the next middleware or the actual handler
-                await _next(context).ConfigureAwait(false);
+                await _next(context);   // NOSONAR
             }
             finally
             {

src/NLog.Web.AspNetCore/NLogRequestPostedBodyMiddleware.cs

@@ -60,7 +60,7 @@ public async Task Invoke(HttpContext context)
                     // This is required, otherwise reading the request will destructively read the request
                     context.Request.EnableBuffering();
 
-                    var requestBody = await ReadPostedBodyFromStream(context.Request.Body).ConfigureAwait(false);
+                    var requestBody = await ReadPostedBodyFromStream(context.Request.Body); // NOSONAR
                     if (!string.IsNullOrEmpty(requestBody))
                     {
                         context.Items[AspNetRequestPostedBodyLayoutRenderer.NLogPostedRequestBodyKey] = requestBody;

tests/NLog.Web.AspNetCore.Tests/NLogRequestLoggingMiddlewareTests.cs

@@ -127,7 +127,7 @@ public void HttpRequestExceptionFilterTest()
             {
                 try
                 {
-                    middlewareInstance.Invoke(defaultContext).ConfigureAwait(false).GetAwaiter().GetResult();
+                    middlewareInstance.Invoke(defaultContext).GetAwaiter().GetResult();
                 }
                 catch
                 {

tests/NLog.Web.AspNetCore.Tests/NLogRequestPostedBodyMiddlewareTests.cs

@@ -147,7 +147,7 @@ public void ContentLengthTooLargeTest()
 
             // Act
             var middlewareInstance = new NLogRequestPostedBodyMiddleware(Next,NLogRequestPostedBodyMiddlewareOptions.Default);
-            middlewareInstance.Invoke(defaultContext).ConfigureAwait(false).GetAwaiter().GetResult();
+            middlewareInstance.Invoke(defaultContext).GetAwaiter().GetResult();
 
             // Assert
             Assert.NotNull(defaultContext.Items);