Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invert ekomark-ekobox dependency #226

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Invert ekomark-ekobox dependency #226

merged 1 commit into from
Mar 21, 2023

Conversation

felixhekhorn
Copy link
Contributor

Closes #122

@felixhekhorn felixhekhorn added refactor Refactor code benchmarks Benchmark (or infrastructure) related dependencies Pull requests that update a dependency file labels Mar 14, 2023
alecandido
alecandido approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since #225 is already approved, please merge before that one

@felixhekhorn felixhekhorn mentioned this pull request Mar 14, 2023
Closed
Base automatically changed from toylh_polarized to master March 14, 2023 16:35
@giacomomagni giacomomagni linked an issue Mar 14, 2023 that may be closed by this pull request
Cut banana out of ekobox #122
Closed
giacomomagni
giacomomagni reviewed Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@giacomomagni giacomomagni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this.
I imagine this will break the dependency in many tools right?

@alecandido
Copy link
Member

I'm fine with this. I imagine this will break the dependency in many tools right?

Only those using apply_pdf directly, in principle (and outside our packages I'm not sure it is used that much).

@andreab1997
Copy link
Contributor

Fine for me, I don't see anything harmful. For sure I will need to update something as @giacomomagni was saying but nothing too complicate I believe.

@felixhekhorn felixhekhorn merged commit 9e33af3 into master Mar 21, 2023
@felixhekhorn felixhekhorn deleted the invert-mark-box-dep branch March 21, 2023 15:26
@felixhekhorn felixhekhorn mentioned this pull request May 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giacomomagni giacomomagni giacomomagni left review comments

@andreab1997 andreab1997 andreab1997 approved these changes

@alecandido alecandido alecandido approved these changes

Assignees
No one assigned
Labels
benchmarks Benchmark (or infrastructure) related dependencies Pull requests that update a dependency file refactor Refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cut banana out of ekobox
4 participants
@felixhekhorn @alecandido @andreab1997 @giacomomagni