Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover SV, ev method, backwards method #394

Merged
merged 13 commits into from
Oct 14, 2024
Merged

Recover SV, ev method, backwards method #394

merged 13 commits into from
Oct 14, 2024

Conversation

felixhekhorn
Copy link
Contributor

@felixhekhorn felixhekhorn commented Jul 19, 2024

  1. recover SV: a "major" change is to use always Lsv in the callbacks
  2. recover evolution method (iterate-exact, etc.) - trivial thanks to Pass evolution + backwards method internally via int #395
  3. recover backwards method - trivial thanks to Pass evolution + backwards method internally via int #395

@felixhekhorn felixhekhorn added refactor Refactor code rust Rust extension related labels Jul 19, 2024
@felixhekhorn felixhekhorn changed the title Recover scale variations Recover SV, ev method, backwards method Aug 9, 2024
@felixhekhorn
Copy link
Contributor Author

cc @tgiani

the last few commits add the LHA benchmark using Rust and eventually I made it running: https://github.com/NNPDF/eko/actions/runs/10791934092/job/29930458728 - to be compared to the last run on master here https://github.com/NNPDF/eko/actions/runs/10683126160/job/29610483008

good things first:

  • it is actually running ✔️ 🙈
  • the benchmark now only takes 5 min as compared to 45 min ✔️ Both timings include compilation and I expect $t_{compile} < t_{run}$ for Rust, but inverse for Numba; recall that based on our previous observation we expect a run time reduction of ~4x
  • the actual numbers are still mostly fine, BUT

the bad news are: they are not the same and even slightly worse ... compare

# small x gluon
0   1.000000e-07  10000.0  ...  1008.400000      -0.114663 # here
# vs.
0   1.000000e-07  10000.0  ...  1008.400000      -0.092259 # master

it's small, but still ... let's implement the missing unit tests in #385 and either we find something or I think we can accept ...

@tgiani
Copy link
Contributor

tgiani commented Sep 10, 2024

@felixhekhorn indeed let me first complete the unit tests in #385, it is well likely that there is some little bug in as2.rs that will be spotted by doing that

@tgiani
Copy link
Contributor

tgiani commented Sep 11, 2024

@felixhekhorn there was indeed a bug in as2. Still need to finish the unit test, maybe there will be more

@felixhekhorn
Copy link
Contributor Author

@felixhekhorn there was indeed a bug in as2. Still need to finish the unit test, maybe there will be more

let's complete the unit tests, but the benchmark numbers seem now one on one to be the same: https://github.com/NNPDF/eko/actions/runs/10829978519/job/30048696220 🎉

@felixhekhorn felixhekhorn requested a review from tgiani October 11, 2024 13:33
Base automatically changed from ome_rust to master October 14, 2024 13:04
@felixhekhorn felixhekhorn merged commit f901489 into master Oct 14, 2024
9 checks passed
@felixhekhorn felixhekhorn deleted the rust_sv branch October 14, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor code rust Rust extension related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants