-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recover SV, ev method, backwards method #394
Conversation
cc @tgiani the last few commits add the LHA benchmark using Rust and eventually I made it running: https://github.com/NNPDF/eko/actions/runs/10791934092/job/29930458728 - to be compared to the last run on master here https://github.com/NNPDF/eko/actions/runs/10683126160/job/29610483008 good things first:
the bad news are: they are not the same and even slightly worse ... compare
it's small, but still ... let's implement the missing unit tests in #385 and either we find something or I think we can accept ... |
@felixhekhorn indeed let me first complete the unit tests in #385, it is well likely that there is some little bug in |
@felixhekhorn there was indeed a bug in |
let's complete the unit tests, but the benchmark numbers seem now one on one to be the same: https://github.com/NNPDF/eko/actions/runs/10829978519/job/30048696220 🎉 |
Lsv
in the callbacks