-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce docformatter and ruff #405
Conversation
Ruff is also doing In principle, the workflows are Pylint-agnostic, as they rely on |
https://docs.astral.sh/ruff/ |
While pydocstyle and pyupgrade were already dropped, dfe7c79 additionally dropps isort and black (I will need to get used to the fact that black will no longer be around after such a long time 🙃 ) - note that there a few changes in the format, but as long as someone is doing the job I don't care about the actual format |
Note that 8bcee93 revealed a naming problem for which I don't have better solution then the one proposed ... other ideas are welcome |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a quick look and indeed the changes are mostly only in docs, with some few variables l
renamed (?)...
I see you are still keeping blacken-docs
.
1149f18 drops
yes, the new linter complained (also pylint would issue a warning) as it considers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay LGTM.
I apologize for this gigantic PR, but I believe we want this and hopefully nothing should have happened.
.
here and there. I did not go through the whole documentation to see, if everything went well (and for sure there are some hickups here and there), but I trust in the docformatter developers.Not sure on how much of a review is required (given the amount of files), but maybe tell me if you agree with the idea.