Merge pull request #2195 from NNPDF/hotfix_check_on_new

Don't change the input variable when checking old-new for DW datasets
NNPDF · Nov 1, 2024 · 09731d4 · 09731d4
2 parents 01eb983 + 581829c
commit 09731d4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/nnpdf_data/nnpdf_data/__init__.py b/nnpdf_data/nnpdf_data/__init__.py
@@ -64,7 +64,7 @@ def new_to_legacy_map(dataset_name, variant_used):
             matches.append(old_name)
             # if it's a nuclear DIS data promote legacy to be legacy_dw
             if "_DW_" in old_name and variant_used == "legacy":
-                variant_used = "legacy_dw"
+                variant = "legacy_dw"
 
             if variant_used == variant:
                 exact_matches.append(old_name)

diff --git a/validphys2/src/validphys/tests/test_commondataparser.py b/validphys2/src/validphys/tests/test_commondataparser.py
@@ -128,3 +128,5 @@ def test_variant_nnpdf_metadata():
         assert pcd2.experiment != pcd1.experiment
         # but the real experiment is the same
         assert cd1.metadata.experiment == cd2.metadata.experiment
+        # And check that the legacy names are _not_ the same
+        assert cd1.legacy_names != cd2.legacy_names