Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run black and isort on entire repo #1955

Closed
wants to merge 1 commit into from
Closed

Run black and isort on entire repo #1955

wants to merge 1 commit into from

Conversation

APJansen
Copy link
Collaborator

Feel free to delete, I don't oversee whether this may be more of a headache than it solves, but I just wanted to get rid of all the diffs that are just from applying black or isort.
So here I did only that, in the top level of the repo, black . and isort ..

There was one file that black couldn't reformat, due to this line which apparently uses Python 2 syntax. I didn't touch that, literally only did the 2 commands above.

@scarlehoff
Copy link
Member

hi @APJansen this cannot be done now because it will create a mess for many branches.

Also, we already did it in the past and people kept on forgetting to add it so the only solution is to add a workflow that lints the code and reminds the user to do it (I'd rather not do it automatically)

@scarlehoff scarlehoff closed this Feb 22, 2024
@RoyStegeman RoyStegeman deleted the black-isort branch February 22, 2024 14:10
@RoyStegeman
Copy link
Member

RoyStegeman commented Feb 22, 2024

We could urge people to use pre-commit and add a dot file with the settings we want?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants