-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementation of CMS_WCHARM_7TEV in the new format #2245
Open
achiefa
wants to merge
8
commits into
master
Choose a base branch
from
new_CMS_WCHARM_7TEV_WPWM
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is still WIP. Here you can find a report of the new implementation, which is preliminary: report
|
5 tasks
achiefa
force-pushed
the
new_CMS_WCHARM_7TEV_WPWM
branch
from
December 13, 2024 09:50
e4bf77e
to
6a5cbb0
Compare
I have finalised the implementation of this dataset. Besides the new report posted in the description of this PR, I have the following comments:
Please, @RoyStegeman have a look at the implementation and let me know if you find something unclear or wrong. |
achiefa
force-pushed
the
new_CMS_WCHARM_7TEV_WPWM
branch
from
December 13, 2024 11:00
2ee81ed
to
5bc8d02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments
This dataset delivers two different observables:
The variant
sys_10
accounts for the 3pt prescription and thus it should be deprecated in the new format.Legacy: [default]
New: [default]