Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the luminosity and bin mask options for FKs to the python interface #273

Merged
merged 8 commits into from
Apr 18, 2024

Conversation

scarlehoff
Copy link
Member

It seems to work. I've just copied it from the grid.

@scarlehoff scarlehoff requested a review from cschwan April 15, 2024 08:33
@cschwan
Copy link
Contributor

cschwan commented Apr 16, 2024

This looks good to me. It would be perfect if you could also add a small test.

@alecandido
Copy link
Member

I'm working on fixing the signature.

Of course, you could drop the last commit and merge, but I believe to be valuable to avoid some overhead (whenever possible).

@scarlehoff
Copy link
Member Author

As you wish, since you are at it please add also the test that @cschwan asked for.

@alecandido alecandido force-pushed the expose_more_options_fkpython branch from 3f2fbf9 to 9bace31 Compare April 16, 2024 12:04
@felixhekhorn felixhekhorn changed the title Expose the luminosity and bin mask options to the python interface Expose the luminosity and bin mask options for FKs to the python interface Apr 16, 2024
@scarlehoff
Copy link
Member Author

Thanks @alecandido

As a note for the future, we should add maybe a test that does the entire grid -> eko-convolution -> fktable and checks that the fktable can be read. Just to get a heads up in case any part of the interface changes.

@cschwan cschwan merged commit bc1de5b into master Apr 18, 2024
7 checks passed
@cschwan cschwan deleted the expose_more_options_fkpython branch April 18, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants