-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use eko.runner.managed.solve
#151
Conversation
But should this be default if it is slower? Maybe it should be a cmdlije option. |
I would argue yes, because (as you experienced yourself) the current default may not converge always and it shouldn't be much slower: yes, there are more write-to-disk operations, but compared to the numerical integration (~mins to hours) this should be negligible (to be proven, but I'm quite sure) |
With the same number of cores it maybe be slightly slower, but the fact that it uses less memory allows us to increase the number of cores to make faster. (This is what I did to compute the evolution eko for QED) |
Yes, and also it was just a transition. We don't want to maintain both, so at some point the |
In principle, it could even be distributed on multiple nodes. The computation is happening in two steps:
We never finished implementing the infrastructure for splitting recipes and merging parts, but it just boils down to file system operations (moving files around). |
Please wait to merge because I'm still not sure this solves the problem. |
I guess this worked at the end right? So we can probably merge. |
Well, I was not able to create the fktables so not sure if the eko is correct or anything but I guess other people has already tested this a lot? |
Yes of course, we know that it is possible, you just need more memory. Of course it is not ideal but it is not related to this PR. |
Can this be merged now? |
@felixhekhorn since Pineko is the main EKO user, if this works for Pineko, shouldn't you make the |
We may want to do this at some point, but since I consider this is a major change (although the user should(tm) never notice), I would delay that |
I agree it's a major change, but eventually it's the same if you do it in Pineko or EKO :P I know that EKO has also other users beyond Pineko, and that you'd like to group this major change with other ones. But if the alternative is to release the major in a couple of months, you could well release a major now with just that, and another one in a couple of months. |
Use the new "jets runner"
Remember that there are still upcoming changes in eko NNPDF/eko#296 which might affect pineko ...
cc @alecandido @scarlehoff