Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --min_as option to convolute #178

Merged
merged 2 commits into from
May 8, 2024
Merged

Add --min_as option to convolute #178

merged 2 commits into from
May 8, 2024

Conversation

scarlehoff
Copy link
Member

Although maybe the way I'm doing it is a bit... convoluted (canned laughter)

@scarlehoff scarlehoff requested review from cschwan and andreab1997 May 8, 2024 09:30
Copy link
Contributor

@andreab1997 andreab1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I was not aware that this feature could be needed. Is there a specific application for which we would need to select only orders beyond, for example, NLO?

Comment on lines 39 to 41
couplings (i.e. the maximum power allowed for each correction)
e.g., max_as = 1, max_al = 0 would select LO QCD only
max_as = 3 instead would select LO, NLO, NNLO QCD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you a comment also about min_as?

@scarlehoff
Copy link
Member Author

scarlehoff commented May 8, 2024

Yes. If you want to create an fktable with only the NNLO contribution for instance. It is not usual (for instance when doing a theory you won't) but we (w/ @cschwan) are using it now to study the NNLO of DY as a function of q.

This is equivalent to doing in pineappl:

pineappl evolve ${grid} ${eko} ${fktable} NNPDF40_nnlo_pch_as_01180 --orders "a2as2"

in pineko it would become

pineko convolute ${grid} ${eko} ${fktable} 3 1 --min_as 3

@andreab1997
Copy link
Contributor

Yes. If you want to create an fktable with only the NNLO contribution for instance. It is not usual (for instance when doing a theory you won't) but we (w/ @cschwan) are using it now to study the NNLO of DY as a function of q.

This is equivalent to doing in pineappl:

pineappl evolve ${grid} ${eko} ${fktable} NNPDF40_nnlo_pch_as_01180 --orders "a2as2"

in pineko it would become

pineko convolute ${grid} ${eko} ${fktable} 3 1 --min_as 3

Yes, I guess that in pineko this is surely not the main feature so it makes sense to implement it as an optional argument. It is fine for me to merge this as soon as the docstrings are updated.

@scarlehoff scarlehoff merged commit cab805c into main May 8, 2024
5 of 6 checks passed
@scarlehoff scarlehoff deleted the add_min_as_option branch May 8, 2024 10:31
@felixhekhorn felixhekhorn added the enhancement New feature or request label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants