-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement generators for nDIS processes #160
base: master
Are you sure you want to change the base?
Conversation
Remember to run |
Maybe you want to have #199 in? (that's why I just merged it) |
Done 😃
Thanks! Just merged it. This is also ready to be reviewed/merged. |
Co-authored-by: Felix Hekhorn <[email protected]>
extras/data/CHORUSPb/metadata.yaml
Outdated
CHORUS_CC_NU_PB_SIGMARED: | ||
description: CHORUS reduced cross section neutrino-nucleon scattering on lead | ||
nnpdf_id: CHORUSNUPb | ||
|
||
CHORUS_NU_PB: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why you need a copy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(similar for others)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is to make sure that the grids are generated assuming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it then not be called EL_P
or similar?
extras/data/BCDMS/metadata.yaml
Outdated
description: BCDMS NC nuclear data | ||
nnpdf_id: BCDMS85FeD | ||
y_label: F2p | ||
y_label_tex: $F_{2,\mathrm{tot}}^{(\mathrm{p})}$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you want to reflect more information here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(similar for others)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this along with the references below, are still something I have to properly add later (during some free time 🙃 ).
|
||
arxiv: null | ||
hepdata: null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arxiv: null | |
hepdata: null | |
arxiv: null | |
hepdata: null |
are there no references?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(similar for others)
The following implements and tracks the$b$ -threhsold). The computation of the corresponding pineapplgrids will be tracked in https://github.com/NNPDF/fktables/issues/34 while the overall status of the benchmarking comparisons will be tracked in NNPDF/pinecards#162.
observable.yaml
generators for both the NC & CC nDIS processes included in the nuclear PDF fits (taking into account the displacedCC Datasets:
CC Datasets:
PS: After some thinking, I believe that this is currently the best place to generate these
observable.yaml
as the changes required wrt to the already existing datasets are minimal.