Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce version file support into develop branch #1644

Merged

Conversation

KateFriedman-NOAA
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA commented May 24, 2023

Description

This PR introduces the use of version files in the develop branch. This initial introduction will use version files for runtime only. The ability to force version files for build is included but commented out for now. A follow-up PR will turn on build version forcing when ready.

Tagging @DavidHuber-NOAA about Jet/S4 updates.

Resolves #671
Resolves #1625

Changes include:

  1. Update module_base.*.lua modulefiles to use module version variables and remove hardcoded versions.
  2. Introduce build.<platform>.ver, run.<platform>.ver files in the /versions folder.
  3. Update sorc/link_workflow.sh to create build.ver and run.ver under /versions folder based on build.<platform>.ver and run.<platform>.ver.
  4. Introduce sourcing of run.ver in ush/load_fv3gfs_modules.sh
  5. Introduce sourcing of build.ver in sorc/build_all.sh but commented out for now. Components will continue setting their module versions for the time being.
  6. Update HOMEens_tracker in config.vrfy to use tracker_ver from version files.
  7. Replace obsproc version in HOMEobsproc setting in parm/config/gfs/config.base.emc.dyn to use obsproc_run_ver from version files.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Clone and Build tests on Hera, Orion, WCOSS2 (no build changes though)
  • Cycled tests on Hera, Orion, WCOSS2 (1.5 cycles - reproduced control with develop)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

KateFriedman-NOAA and others added 30 commits July 19, 2022 19:34
- In move to WCOSS2 the transfer*list files were moved into a new
transfer folder under the upper-level parm folder.

Refs: NOAA-EMC#419
- The transfer*list files were updated in operations during the move
from WCOSS1 to WCOSS2.
- The beginning of the path within the transfer*list files was updated
from:
  com/gfs/_ENVIR_
to:
  _COMROOT_/gfs/_SHORTVER_

Refs: NOAA-EMC#419
- Add release notes for GFSv16.1 and GFSv16.2 versions that were added
into the operations branch but not yet in the develop branch.

Refs: NOAA-EMC#419
* develop:
  Updated GFS transfer*list files from operations (develop) (NOAA-EMC#918)
- Add /gempak subfolder where needed in gempak ush scripts.
- Remove unneeded commented out path settings from older iterations.

Refs: NOAA-EMC#419
- Cleaning out older GFS version release notes.
- Includes current GFSv16.2.1 release notes, will commit GFSv16.3
release notes with implementation this fall.
- Will then keep only the latest release notes moving forward.

Refs: NOAA-EMC#419
* develop:
  Add postsnd job when bufrsnd it on (NOAA-EMC#926)
- New folder called "versions" for holding .ver files
- New build.ver for setting versions at buildtime
- New run.ver for setting versions at runtime
- New $target.ver files for setting additional non-ops developer
versions for support target platforms (WCOSS2, Hera, Orion)

Refs: NOAA-EMC#419
* develop:
  Add GDASapp (first wave of JEDI changes) (NOAA-EMC#871)
* develop:
  WCOSS2 gempak ush scripts updates and cleanup of old release notes (NOAA-EMC#920)
* develop:
  change gdasechgres dependency to just gdasefcs01 instead of gdasefmn (NOAA-EMC#933)
  Remove obsolete platforms (WCOSS1, Dell, Cray, Theia) references. (NOAA-EMC#922)
  Optimize DA clone, build, and link (NOAA-EMC#931)
- Add WCOSS2 block to machine-setup.sh
- Update the Hera and Orion blocks to use module reset instead of module
purge.
- Add version file sourcing (build.ver and $target.ver).

Refs: NOAA-EMC#419
- Create modulefile.ww3.wcoss2.lua and workflow_utils.wcoss2.lua with
version variables within for building WW3 and workflow_utils.

Refs: NOAA-EMC#419
- Replace hardcoded module versions with version variables in runtime
and build modulefiles for Hera, Orion, and Jet.
- Module versions will be sources from new version files at build or
runtime.

Refs: NOAA-EMC#671
* develop:
  Initial commit of directory comparison tools (NOAA-EMC#934)
  Add preamble, convert to bash, and remove env (NOAA-EMC#929)
  minimal intervention to create a data-atmosphere xml (NOAA-EMC#936)
  Remove Cray, Dell, WCOSS1 from module-setup.sh.inc (NOAA-EMC#943)
  bring GDASApp jjobs and exscripts to global-workflow (NOAA-EMC#941)
- Version updates within build.ver, run.ver and target specific ver
files for Hera and Orion.

Refs: NOAA-EMC#671, NOAA-EMC#419
- Add version file sourcing to load_fv3gfs_module.sh for use at runtime.
- Add WCOSS2 block to load_fv3gfs_module.sh.

Refs: NOAA-EMC#419, NOAA-EMC#671
* develop:
  Remove SDATE=CDATE IAU block in NCO config.base (NOAA-EMC#963)
  Updates for P8  (NOAA-EMC#946)
  Fix GLDAS j-job link (NOAA-EMC#954)
  Add ocean post to archive dependencies (NOAA-EMC#949)
- Updated cmake_ver to 3.20.1
- Remove esmf_ver and cdo_ver; build.ver versions good on Hera

Refs: NOAA-EMC#671
- Convert workflow_utils.jet.lua to use version variables instead of hardcoded versions

Refs: NOAA-EMC#671
- Change references to "png" to "libpng" in modulefiles.
- If using 2022 intel modules then it's libpng.

Refs: NOAA-EMC#671
- Build errors without loading w3nco, will reevaluate removing
the w3nco module load later.

Refs: NOAA-EMC#671
@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion label May 27, 2023
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion labels May 27, 2023
@emcbot
Copy link

emcbot commented May 27, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Sat May 27 01:48:49 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Sat May 27 01:50:47 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Sat May 27 03:00:39 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Sat May 27 03:00:47 CDT 2023 for experiment C96_atm3DVar

@emcbot emcbot added CI-Orion-Failed **Bot use only** CI testing on Orion for this PR has failed and removed CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress labels May 27, 2023
@emcbot
Copy link

emcbot commented May 27, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Sat May 27 01:48:49 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Sat May 27 01:50:47 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Sat May 27 03:00:39 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Sat May 27 03:00:47 CDT 2023 for experiment C96_atm3DVar
Experiment C96_atm3DVar Terminated: *FAILED*
Experiment C96_atm3DVar Terminated with 1 tasks failed at Sat May 27 04:00:12 CDT 2023
Error logs:
/work2/noaa/stmp/GFS_CI_ROOT/PR/1644/RUNTESTS/C96_atm3DVar/COMROT/C96_atm3DVar/logs/2021122100/gdasanaldiag.log

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion and removed CI-Orion-Failed **Bot use only** CI testing on Orion for this PR has failed labels May 28, 2023
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Orion-Failed **Bot use only** CI testing on Orion for this PR has failed and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion labels May 28, 2023
@emcbot
Copy link

emcbot commented May 28, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Sat May 27 20:44:47 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Sat May 27 20:46:32 CDT 2023
Build:                         *FAILED*
Build: Failed at Sat May 27 21:56:48 CDT 2023
Build: see output at /work2/noaa/stmp/GFS_CI_ROOT/PR/1644/global-workflow/sorc/log.build

Failed on cloning and building global-workflowi PR: 1644
CI on Orion failed to build on Sat May 27 21:56:49 CDT 2023 for repo https://github.com/NOAA-EMC/global-workflow.git

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion and removed CI-Orion-Failed **Bot use only** CI testing on Orion for this PR has failed labels May 28, 2023
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion labels May 28, 2023
@emcbot
Copy link

emcbot commented May 28, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Sun May 28 01:00:54 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Sun May 28 01:02:41 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Sun May 28 02:14:12 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Sun May 28 02:14:20 CDT 2023 for experiment C96_atm3DVar

@emcbot
Copy link

emcbot commented May 28, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Sun May 28 01:00:54 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Sun May 28 01:02:41 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Sun May 28 02:14:12 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Sun May 28 02:14:20 CDT 2023 for experiment C96_atm3DVar
Experiment C96_atm3DVar completed: *SUCCESS*
Experiment C96_atm3DVar Completed at Sun May 28 04:35:13 CDT 2023
with 73 successfully completed jobs

@emcbot emcbot added CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully and removed CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress labels May 28, 2023
@emcbot
Copy link

emcbot commented May 28, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Sun May 28 01:00:54 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Sun May 28 01:02:41 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Sun May 28 02:14:12 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Sun May 28 02:14:20 CDT 2023 for experiment C96_atm3DVar
Experiment C96_atm3DVar completed: *SUCCESS*
Experiment C96_atm3DVar Completed at Sun May 28 04:35:13 CDT 2023
with 73 successfully completed jobs

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 7db6208 into NOAA-EMC:develop May 30, 2023
@KateFriedman-NOAA KateFriedman-NOAA deleted the feature/version-files branch November 15, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update wgrib2 from 2.0.7 to 2.0.8 on wcoss2 Introduce version files and their usage in develop branch
6 participants