-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various wave updates: Reformat WW3 inputs; enable PIO for wave restarts; enable WW3 cycling; synchronize UFS restart writes; add uglo_15km WW3 grid #3190
base: develop
Are you sure you want to change the base?
Conversation
Conflicts: .gitmodules
…reading if desired
…combineforww3testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the recent updates from the ufs-weather-model, I did a second pass on this PR.
Please let me know if you have any questions or need further clarification
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup. A few suggestions to make the distinction between binary and netcdf restarts explicit.
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
We can set the labels to test if you are ready for it.
fix files are still needed and I'm working to stage high-res ICs. Running a last test or two before I'm ready to pass off the fix files. Also - as soon as #3188 is merged, there will be conflicts to resolve. |
Description
This PR adds the following:
Notes on ufs-weather-model updates:
Note this PR requires the following:
Co-author: @sbanihash
Related Issues:
Type of change
Change characteristics
How has this been tested?
Tests were done by adding waves to C48mx500 3DVar tests for cycling.
High resolution tests cases were also added.
This likely needs a new round of testing before CI and after staged ICs & new fix files are added.
Checklist