Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first python test! #478

Merged
merged 32 commits into from
Sep 10, 2024
Merged

first python test! #478

merged 32 commits into from
Sep 10, 2024

Conversation

edwardhartnett
Copy link
Contributor

DESCRIPTION OF CHANGES:

Added the first (of many) python test.

This test is for the misc.py file under ush/python_utils. It's a nice simple code to start with.

TESTS CONDUCTED:

N/A

Machines/Platforms:

N/A

Test cases:

N/A

ISSUE:

Part of #456

Copy link
Contributor

@BenjaminBlake-NOAA BenjaminBlake-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edwardhartnett Looks good to me, thanks! Just curious what is the purpose of the pyproject.toml file? I'm unfamiliar with .toml files.

@edwardhartnett
Copy link
Contributor Author

The pyproject.toml is the standard python way to pass options to all the build tools. Used to be each tool kept it's own config files, but that was a giant mess, so current best practice is to organize all tool settings in pyproject.toml. You will see more settings go into this file as we improve the python project.

For more info:
https://packaging.python.org/en/latest/guides/writing-pyproject-toml/

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit c32d9f8 into NOAA-EMC:dev-sci Sep 10, 2024
1 check passed
@MatthewPyle-NOAA
Copy link
Contributor

@edwardhartnett After merging, I realized the pyproject.toml file is in the main level directory. Particularly for systems going to production, the main level directory should pretty sparse, filled mainly with various subdirectories (exec, fix, jobs, parm, scripts, sorc, ush, ...). Could it be tucked under the tests/ space, or is it critical to be within the main level directory?

MatthewPyle-NOAA added a commit to MatthewPyle-NOAA/rrfs-workflow that referenced this pull request Sep 10, 2024
MatthewPyle-NOAA added a commit that referenced this pull request Sep 19, 2024
 but have a question about the location of the .toml file.
@edwardhartnett edwardhartnett deleted the ejh_t5 branch October 1, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants