Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More pp fixes #571

Merged
merged 4 commits into from
May 21, 2024
Merged

Conversation

wrongkindofdoctor
Copy link
Collaborator

Description

  • Update pp query to search for level-specific and 4D variables if necessary
  • define the name correctly in precip rate to flux edit_request
  • move the new translated varlist object with 4D information to an alternate entry to query if no level-specific variable is found in the catalog in extract level function edit_request
  • incorporated existing catalog query updates from @jtmims
    Associated issue # (replace this phrase and parentheses with the issue number)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes in enough detail that
someone can reproduce them. Include any relevant details for your test configuration
such as the Python version, package versions, expected POD wallclock time, and the
operating system(s) you ran your tests on.

Checklist:

  • My branch is up-to-date with the NOAA-GFDL main branch, and all merge conflicts are resolved
  • The scripts are written in Python 3.11 or above (preferred; required if funded by a CPO grant), NCL, or R
  • All of my scripts are in the diagnostics/[POD short name] subdirectory, and include a main_driver script, template html, and settings.jsonc file
  • I have made corresponding changes to the documentation in the POD's doc/ subdirectory
  • I have requested that the framework developers add packages required by my POD to the python3, NCL, or R environment yaml file if necessary, and my environment builds with conda_env_setup.sh
  • I have added any necessary data to input_data/obs_data/[pod short name] and/or input_data/model/[pod short name]
  • My code is portable; it uses MDTF environment variables, and does not contain hard-coded file or directory paths
  • I have provided the code to generate digested data files from raw data files
  • Each digested data file generated by the script contains numerical data (no figures), and is 3 GB or less in size
  • I have included copies of the figures generated by the POD in the pull request
  • The repository contains no extra test scripts or data files

…ed to translatedvarlistentry

that is set in the preprocessor query method
move 4D translated varlist entry info to an alternate attribute entry in the existing translation object in ExtractLevelFunction edit_request
update query logic to search for both level-specific and 4D variables in the catalog if necessary
@wrongkindofdoctor wrongkindofdoctor self-assigned this May 21, 2024
@wrongkindofdoctor wrongkindofdoctor added the framework Issue pertains to the framework code label May 21, 2024
@wrongkindofdoctor wrongkindofdoctor merged commit d641132 into NOAA-GFDL:main May 21, 2024
2 of 4 checks passed
@wrongkindofdoctor wrongkindofdoctor deleted the more_pp_fixes branch May 21, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework Issue pertains to the framework code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant