Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xr parser issues #612

Merged

Conversation

wrongkindofdoctor
Copy link
Collaborator

@wrongkindofdoctor wrongkindofdoctor commented Jul 10, 2024

Description
Add support for multi-value scalar coordinates (e.g., plev19) in xarray dataset to preprocessor and xr_parser functions

Associated issue # (replace this phrase and parentheses with the issue number)

How Has This Been Tested?
RHEL8

Checklist:

  • My branch is up-to-date with the NOAA-GFDL main branch, and all merge conflicts are resolved
  • The scripts are written in Python 3.11 or above (preferred; required if funded by a CPO grant), NCL, or R
  • All of my scripts are in the diagnostics/[POD short name] subdirectory, and include a main_driver script, template html, and settings.jsonc file
  • I have made corresponding changes to the documentation in the POD's doc/ subdirectory
  • I have requested that the framework developers add packages required by my POD to the python3, NCL, or R environment yaml file if necessary, and my environment builds with conda_env_setup.sh
  • I have added any necessary data to input_data/obs_data/[pod short name] and/or input_data/model/[pod short name]
  • My code is portable; it uses MDTF environment variables, and does not contain hard-coded file or directory paths
  • I have provided the code to generate digested data files from raw data files
  • Each digested data file generated by the script contains numerical data (no figures), and is 3 GB or less in size
  • I have included copies of the figures generated by the POD in the pull request
  • The repository contains no extra test scripts or data files

@wrongkindofdoctor wrongkindofdoctor self-assigned this Jul 10, 2024
@wrongkindofdoctor wrongkindofdoctor added the framework Issue pertains to the framework code label Jul 10, 2024
… in the preprocessor.process case_list loop

add support for multi-value scalar_coords to ConvertUnitsFunction
@wrongkindofdoctor wrongkindofdoctor marked this pull request as ready for review July 11, 2024 15:46
@wrongkindofdoctor wrongkindofdoctor merged commit 82b7cfb into NOAA-GFDL:main Jul 11, 2024
3 of 5 checks passed
@wrongkindofdoctor wrongkindofdoctor deleted the fix_xr_parser_issues branch July 11, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework Issue pertains to the framework code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant