Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iss 677 #679

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Iss 677 #679

merged 3 commits into from
Sep 4, 2024

Conversation

wrongkindofdoctor
Copy link
Collaborator

@wrongkindofdoctor wrongkindofdoctor commented Sep 4, 2024

Description

  • add variable_id back to catalog query
  • refine fieldlist lookup table search for 4D field base names only to ensure unique entries for standard_name are returned. The variable_id for a single level is then inferred from the scalar_coords attribute in the pod settings file as before.
  • fix definition of ds_names list in xr_parser reconcile_names
  • fix bad entries in GFDL field table
  • comment out $refs in gfdl field table variables block as current configuration does not handle multiple json $refs in a single block
  • Note that the Wheeler-Kiladis POD will not run with the test catalog linked in the associated issue because several standard_name entries are missing for variables--in particular ua200.
    Associated issue cannot access ds_names  #677

How Has This Been Tested?
RHEL 8 with EOF500 hPa POD 1980-1990

Checklist:

  • My branch is up-to-date with the NOAA-GFDL main branch, and all merge conflicts are resolved
  • The scripts are written in Python 3.12 or above (preferred; required if funded by a CPO grant), NCL, or R
  • All of my scripts are in the diagnostics/[POD short name] subdirectory, and include a main_driver script, template html, and settings.jsonc file
  • I have made corresponding changes to the documentation in the POD's doc/ subdirectory
  • I have requested that the framework developers add packages required by my POD to the python3, NCL, or R environment yaml file if necessary, and my environment builds with conda_env_setup.sh
  • I have added any necessary data to input_data/obs_data/[pod short name] and/or input_data/model/[pod short name]
  • My code is portable; it uses MDTF environment variables, and does not contain hard-coded file or directory paths
  • I have provided the code to generate digested data files from raw data files
  • Each digested data file generated by the script contains numerical data (no figures), and is 3 GB or less in size
  • I have included copies of the figures generated by the POD in the pull request
  • The repository contains no extra test scripts or data files

comment out  entries in GFDL_fieldlist--need to refactor b/c multiple refs can't be parsed with current config
add more descriptive error message for missing file assets in the event of a failed catalog query
@wrongkindofdoctor wrongkindofdoctor added bug Something isn't working framework Issue pertains to the framework code labels Sep 4, 2024
@wrongkindofdoctor wrongkindofdoctor self-assigned this Sep 4, 2024
@wrongkindofdoctor wrongkindofdoctor merged commit 8de25fa into NOAA-GFDL:main Sep 4, 2024
3 checks passed
@wrongkindofdoctor wrongkindofdoctor deleted the iss_677 branch September 4, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working framework Issue pertains to the framework code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant