Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci bugs #688

Merged
merged 30 commits into from
Sep 18, 2024
Merged

Fix ci bugs #688

merged 30 commits into from
Sep 18, 2024

Conversation

wrongkindofdoctor
Copy link
Collaborator

@wrongkindofdoctor wrongkindofdoctor commented Sep 13, 2024

Description

  • Reconfigure translation to work with case-sensitive variable names
  • Change pod_setup logic to only set dummy no_translation fieldlist if translate_data is false in runtime config, not if pod and dataset conventions match since the varlist still needs to populate information for level variables that may be extracted from 4D fields
  • resolve issues in translate_coord caused by trying to pass a generator that returns a dictionary to copy.deepcopy

Associated issue # (replace this phrase and parentheses with the issue number)

How Has This Been Tested?
RHEL8, Python 3.12

Checklist:

  • My branch is up-to-date with the NOAA-GFDL main branch, and all merge conflicts are resolved
  • The scripts are written in Python 3.12 or above (preferred; required if funded by a CPO grant), NCL, or R
  • All of my scripts are in the diagnostics/[POD short name] subdirectory, and include a main_driver script, template html, and settings.jsonc file
  • I have made corresponding changes to the documentation in the POD's doc/ subdirectory
  • I have requested that the framework developers add packages required by my POD to the python3, NCL, or R environment yaml file if necessary, and my environment builds with conda_env_setup.sh
  • I have added any necessary data to input_data/obs_data/[pod short name] and/or input_data/model/[pod short name]
  • My code is portable; it uses MDTF environment variables, and does not contain hard-coded file or directory paths
  • I have provided the code to generate digested data files from raw data files
  • Each digested data file generated by the script contains numerical data (no figures), and is 3 GB or less in size
  • I have included copies of the figures generated by the POD in the pull request
  • The repository contains no extra test scripts or data files

@wrongkindofdoctor wrongkindofdoctor added bug Something isn't working framework Issue pertains to the framework code labels Sep 13, 2024
@wrongkindofdoctor wrongkindofdoctor self-assigned this Sep 13, 2024
… the var object instead of the var.translation object if True to preprocessor
…args to return 1hr instead of hr so that the frequency for hourly data matchew required catalog specification
split group 1 CI tests into 2 runs to avoid timeout issues
just run 1 POD in set1 tests
try adding timeouts mdtf_tests.yml
…unction

redefine dest_unit using var.units.units so that parm is a string instead of a Units.units object in call to units.convert_dataarray
…_parser.compare_attr so that values can be converted later
add check to convert mb to hPa to convertdataarray
@wrongkindofdoctor wrongkindofdoctor marked this pull request as ready for review September 18, 2024 21:27
@wrongkindofdoctor wrongkindofdoctor merged commit f3cd54b into NOAA-GFDL:main Sep 18, 2024
4 of 5 checks passed
@wrongkindofdoctor wrongkindofdoctor deleted the fix_ci_bugs branch September 18, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working framework Issue pertains to the framework code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant