Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidal angular frequency has units [rad s-1] #764

Open
wants to merge 2 commits into
base: dev/gfdl
Choose a base branch
from
Open

Tidal angular frequency has units [rad s-1] #764

wants to merge 2 commits into from

Commits on Nov 30, 2024

  1. Tidal angular frequency has units [rad s-1] 

    Tidal frequencies are always angular frequencies to simplify applying
sine and cosine.  These have MKS units [rad s-1] but they are all
currently listed as [s-1].

Updated dOxygen comments for variables, e.g. [T-1 ~> s-1] becomes
[rad T-1 ~> rad s-1].  Updated get_param units. e.g. units="s-1"
becomes units="rad s-1".

No answers are changed, but the logged parameter units are different.

There are frequencies in MOM_internal_tides.F90 but these have not
been updated because they may be specified incorrectly.  They are
used as if they are [T-1] but they are calculated as 2PI/period [rad T-1].

  real, allocatable, dimension(:) :: frequency  !< The frequency of each band [T-1 ~> s-1].

  real    :: period             ! A tidal period read from namelist [T ~> s]

  ! The periods of the tidal constituents for internal tides raytracing
  call read_param(param_file, "TIDAL_PERIODS", periods)

  do fr=1,num_freq
    period = US%s_to_T*extract_real(periods, " ,", fr, 0.)
    CS%frequency(fr) = 8.0*atan(1.0)/period
  enddo

All MOM6-examples cases have INTERNAL_TIDES=False and so can't
resolve this issue.
    @awallcraft
    awallcraft committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    48c83d9 View commit details
    Browse the repository at this point in the history

  2. fixed too-long line

    @awallcraft
    awallcraft committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    ea9aedd View commit details
    Browse the repository at this point in the history