Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 'os-latest` in ngen ci #50

Merged
merged 1 commit into from
Apr 26, 2024
Merged

use 'os-latest` in ngen ci #50

merged 1 commit into from
Apr 26, 2024

Conversation

madMatchstick
Copy link
Contributor

Workflow ngen_integration specifically calls out mac & ubuntu versions; lets update to -latest.

Fixes issue #49

@SnowHydrology SnowHydrology merged commit c9aa4c8 into master Apr 26, 2024
4 checks passed
@madMatchstick madMatchstick deleted the madMatchstick-patch-1 branch April 26, 2024 18:53
@PhilMiller
Copy link
Contributor

Ack, I wish I'd seen this a bit faster. I would have recommended specifying ubuntu-22.04 and keeping macos-12. The challenge with using -latest is that toolchain and other configuration changes can appear unexpectedly, when the first PR gets pushed after Github makes an update, and fail for unrelated reasons. When we're being relatively strict about compiler warnings that can change from one compiler version to another, that potentially causes a lot of turmoil.

@madMatchstick
Copy link
Contributor Author

@PhilMiller - This one is easily revert-able. I've noticed that many of the other formulation ngen_integration workflows use -latest which is why I brought it about. We can definitely work on specifying ubuntu and mac versions here on out... -thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants