Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MADIS DA #38

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

yuanxue2870
Copy link

@yuanxue2870 yuanxue2870 commented Dec 5, 2024

Describe your changes

Summarise all code changes included in PR:

  1. add MADIS yaml
  2. add MADIS observations directory

List any associated PRs in the submodules.
NOAA-PSL/land-DA_update#28

Issue ticket number and link

List the git Issue that this PR addresses:
#39

Test output

Is this PR expected to pass the DA_IMS_test (ie., does it change the output)?
Yes.
Does it pass the DA_IMS_test?
Yes.
If changes to the test results are expected, what are these changes? Provide a link to the output directory when running the test:
N/A

Checklist before requesting a review

  • My branch being merged is up to date with the latest develop.
  • I have performed a self-review of my code by examining the differences that will be merged.
  • I have not made any unnecessary code changes / changed any default behavior.
  • My code passes the DA_IMS_test, or differences can be explained.

@yuanxue2870
Copy link
Author

@ClaraDraper-NOAA, @jiaruidong2017, Please review, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant