-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature update: instrument and satellite meta tables for arrays #39
Conversation
need to add the updated tables to the readme |
ReadME has been updated and the PR is fully ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can reproduce passing unit tests. Noting here to also include in this PR a new namedtuple in src/harvest_translator.py that corresponds to the new expt_array_metrics table.
I provided a few minor (stylistic) comments to consider.
Co-authored-by: Adam Schneider <[email protected]>
…-PSL/score-db into feature/sat-instrument-meta
confirming at this point that all tests are running successfully with the new changes. since we don't have any harvesters set up for the array metrics, I can't write in a realistic test for the new harvest with is_array part |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests are passing for me, and everything else looks good. Double checked code and readme changes against the db schema changes as well. I think this is good to go.
This PR adjusts how satellite and instrument information is stored and related to array metrics and types. Previously, we had a single satellite meta down to the channel associated with a type, this was too restrictive. This PR splits this information into two tables sat_meta (sat id, name, short name) and instrument meta (name, num channels, scan angle) and associates them separately between the array metric type (instrument) and array metric values (specific sat).
This will extend our ability to use the satellite and instrument in flexible ways for arrays. In the future, these tables can also be associated with the experiment metric and metric types tables for single values.
Modified files for the new table structures and relationships, handler files and testing, and added new files for instrument meta handler and tests.
I also commented out the harvest innov stats tests which is a known failure and complicated testing procedures (this should be addressed in future PRs and has been captured as issue #38)