-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PLATFORM-1077) Adding CI/CD capabilities and Unit Tests #76
base: master
Are you sure you want to change the base?
Conversation
Hi, @kbooker79 . Can you please sync up the PR branch with master? |
n_var_lndp = 2 | ||
/ | ||
|
||
&nam_sppperts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are the options for SPP (note that these are the generally recommended settings to run SPP at 3-km in the SRW App; I've not tested it with any other UFS App or at different grid resolutions):
DO_SPP: true
N_VAR_SPP: 5
SPP_VAR_LIST: "pbl", "sfc", "mp", "rad", "gwd"
SPP_MAG_LIST: 0.2, 0.2, 0.75, 0.2, 0.2
SPP_LSCALE: 150000.0, 150000.0, 150000.0, 150000.0, 150000.0
SPP_TSCALE: 21600.0, 21600.0, 21600.0, 21600.0, 21600.0
SPP_SIGTOP1: 0.1, 0.1, 0.1, 0.1, 0.1
SPP_SIGTOP2: 0.025, 0.025, 0.025, 0.025, 0.025
SPP_STDDEV_CUTOFF: 1.5, 1.5, 2.5, 1.5, 1.5
ISEED_SPP: 4, 5, 6, 7, 8
Note that EMC implemented SPP for the Grell-Frietas scheme, which can be turned on by adding "cu_deep" to the SPP_VAR_LIST variable and adding an additional value to the other namelist entries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, @JeffBeck-NOAA. I've added the changes to input.nml. I added "cu_deep" as an additional variable to SPP_VAR_LIST as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zach1221, did n_var_spp not work with 6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeffBeck-NOAA yes, looks like it failed with the below. I was going to try with 5, but Hera is down for maintenance currently.
At line 182 of file compns_stochy.F90 (unit = 21, file = 'input.nml')
1: Fortran runtime error: Cannot match namelist object name spp_var_list:
@JeffBeck-NOAA I tested out the unit test pipeline, following our changes. Following the srun command (srun --label -A epic -n 24 standalone_stochy.x), the pipeline failed with the below. At line 182 of file compns_stochy.F90 (unit = 21, file = 'input.nml') Does do_spp need to be enabled in compns_stochy.F90 as well, perhaps? |
Sorry, @zach1221. The following needs to be in the &gfs_physics_nml (not &nam_sppperts) section of input.nml: do_spp = .true. |
This PR enables running of the standalone Stochastic Physics unit tests, and automation of the standalone unit tests through the addition of a jenkins pipeline integration. The pipeline is spun-up via git labels and executed through a newly created jenkinsfile script.