Replay Mover Updates #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariahpope
reviewed
Mar 19, 2024
There was a problem hiding this comment.
yep these were the exact same bugs I found!
- import logging was needed
- in def(run) when you called move_single_dataset it would say replay doesn't exist so had to be fixed.
I did not make the updates to region on my end, but I see why that was needed. I think one time I got an error that "pfull" didnt exist because none of the variables in that specific run had that dimension so I think I just commented out pfull and it worked fine. But anyways -- this is an actual fix!
mariahpope
reviewed
Mar 19, 2024
|
Thanks @mariahpope for checking it out! I'll go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to replay mover after rechunking and appending variables to the 1/4 degree dataset. This includes some bugs in replay_mover that I accidentally put into #5 (that's what happens when I clean up and don't test things I guess).