Skip to content

Commit

Permalink
fix: locale and layouts errors (nodejs#6134)
Browse files Browse the repository at this point in the history
  • Loading branch information
ovflowd authored Nov 21, 2023
1 parent 9b37e2d commit 5f56779
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 51 deletions.
31 changes: 0 additions & 31 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,20 +79,6 @@ jobs:
# regardless of having code changes or not
fetch-depth: 1

- name: Restore Build Cache
uses: actions/cache/restore@704facf57e6136b1bc63b828d79edcd491f0ee84 # v3.3.2
with:
path: |
.turbo/cache
.next/cache
node_modules/.cache
# We want to restore cache from local .npm caches, .next/cache and node_modules/.cache
# As this should reduce build times, and the overall time for installing packages or running operations
key: cache-build-${{ hashFiles('package-lock.json') }}-
restore-keys: |
cache-build-${{ hashFiles('package-lock.json') }}-
cache-build-
- name: Set up Node.js
uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
with:
Expand Down Expand Up @@ -132,20 +118,3 @@ jobs:
# this should be a last resort in case by any chances the build memory gets too high
# but in general this should never happen
NODE_OPTIONS: '--max_old_space_size=4096'

- name: Save Build Cache
# We want to store the Build Cache within Pull Requests or during pushes against the `main` branch
# since caches created on the `main` (default) branch can be reused on Pull Requests and PRs coming from forks
if: |
github.event_name == 'push' || github.event_name == 'pull_request_target'
uses: actions/cache/save@704facf57e6136b1bc63b828d79edcd491f0ee84 # v3.3.2
with:
path: |
.turbo/cache
.next/cache
node_modules/.cache
# Most of sibling Pull Requests will use the cache key based on the package-lock.json
# We do also add a hashFiles for `.next/cache` as GitHub Actions only allows
# One cache with same key to exist, so to ensure we always have a cache from the latest build
# We add the hashFiles of `.next/cache` to the cache key of the Cache Entry
key: cache-build-${{ hashFiles('package-lock.json') }}-${{ hashFiles('.next/cache/**') }}
File renamed without changes.
16 changes: 14 additions & 2 deletions app/[locale]/not-found.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
import NotFound from '@/app/not-found';
import { useTranslations } from 'next-intl';
import type { FC } from 'react';

export default NotFound;
const LocalizedNotFound: FC = () => {
const t = useTranslations();

return (
<div className="container">
<h2>{t('pages.404.title')}</h2>
<h3>{t('pages.404.description')}</h3>
</div>
);
};

export default LocalizedNotFound;
18 changes: 0 additions & 18 deletions app/not-found.tsx

This file was deleted.

0 comments on commit 5f56779

Please sign in to comment.