Skip to content

Commit

Permalink
meta: remove remark-gfm (and update dependabot) (nodejs#5806)
Browse files Browse the repository at this point in the history
* meta: remove remark-gfm (and update dependabot)

* meta: alert us that things are unhappy
  • Loading branch information
ovflowd authored Sep 19, 2023
1 parent 4950bd9 commit c48b65e
Show file tree
Hide file tree
Showing 6 changed files with 2,952 additions and 7,432 deletions.
5 changes: 3 additions & 2 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,12 @@ updates:
- 'next-sitemap'
- 'next-themes'
- '@vercel/*'
remark-mdx:
mdx:
patterns:
- '@vcarl/remark-headings'
- 'remark-gfm'
- '@mdx-js/*'
- 'rehype-*'
- 'remark-*'
react:
patterns:
- 'react'
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@ jobs:
# We only run full static builds within Pull Requests. As they're not needed on `merge_group` or `push` events
# Note that we skip full static builds on Crowdin-based Pull Requests as these PRs should only contain translation changes
if: |
github.event_name == 'pull_request_target' && github.event.pull_request.head.ref != 'chore/crowdin'
(github.event_name == 'push') ||
(github.event_name == 'pull_request_target' &&
github.event.pull_request.head.ref != 'chore/crowdin')
# We want to enforce that the actual `turbo@latest` package is used instead of a possible hijack from the user
# the `${{ steps.turborepo_arguments.outputs.turbo_args }}` is a string substitution coming from a previous step
run: npx --package=turbo@latest -- turbo deploy ${{ steps.turborepo_arguments.outputs.turbo_args }}
Expand Down
1 change: 0 additions & 1 deletion COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,6 @@ MDX is becoming the standard for parsing human-content on React/Next.js-based Ap

Some of the plugins that we use include:

- `remark-gfm`: Allows us to use GitHub Flavored Markdown
- `remark-headings`: Generates Metadata for Markdown Headings
- This allows us to build the Table of Contents for each Page, for example.
- `rehype-autolink-headings`: Allows us to add Anchor Links to Markdown Headings
Expand Down
3 changes: 1 addition & 2 deletions next.dynamic.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { join, normalize, sep } from 'node:path';
import { readFileSync } from 'node:fs';
import { VFile } from 'vfile';
import { getHighlighter } from 'shiki';
import remarkGfm from 'remark-gfm';
import remarkHeadings from '@vcarl/remark-headings';
import rehypeAutolinkHeadings from 'rehype-autolink-headings';
import rehypePrettyCode from 'rehype-pretty-code';
Expand Down Expand Up @@ -176,7 +175,7 @@ export const generateStaticProps = async (source = '', filename = '') => {
},
],
],
remarkPlugins: [remarkGfm, remarkHeadings],
remarkPlugins: [remarkHeadings],
format: filename.includes('.mdx') ? 'mdx' : 'md',
},
});
Expand Down
Loading

0 comments on commit c48b65e

Please sign in to comment.