forked from nodejs/nodejs.org
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from nodejs:main #272
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: create Notification component
Vulnerable Libraries (2)
More info on how to fix Vulnerable Libraries in JavaScript. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
feat: create NavItem component
* Feat: add Common/Pagination initial rendering test and markdown * Feat: add currentPage and pages props to Common/Pagination component * Feat: add disabled logic to previous and next buttons in Common/Pagination component * Feat: create and add initial logic to useGetParsedPages, to manage pages shown in Common/Pagination * Feat: show an ellipsis when there are more than 6 pages in Common/Pagination * Refactor: abstract common test code into a setUpTest function in Common/Pagination tests * Feat: add currentPageSiblingsCount prop, and update useGetPageElements hook with ellipsis logic * Feat: add initial stories for Common/Pagination component * Feat: add aria-current modifier in tailwind.config.ts * Feat: add initial Tailwind styles to all Common/Pagination HTML elements * Refactor: move styles of Common/Pagination component to index.module.css * Feat: add internationalization to Common/Pagination component * Fix: add missing responsive styles in Common/Pagination index.module.css * Refactor: add some minor updates to Common/Pagination component * Refactor: split useGetPageElements code into sub-components, refactor its code, and document it through comments * Feat: add nextJsRouter.mjs mock in __mocks__ directory, and import it within jest.setup.mjs * Feat: add PaginationListItem unit tests, and minor refactors to improve code consistency
* feat(components): add `Breadcrumbs` component * feat(Storybook): add Breadcrumbs Hidden Home story * fix(Breadcrumbs): fix CSS indentation * fix(Breadcrumbs): fix typo * fix(Breadcrumbs): fix eslint import order * refactor(Breadcrumbs): split Breadcrumb into sub components * style(Breadcrumbs): remove comment and update component * fix(Breadcrumbs): use LocalizedLink * style(Breadcrumbs): remove abbreviation * refactor(Breadcrumbs): improve code readability * style(Breadcrumbs): format Breadcrumbs story * fix(Breadcrumbs): add default value for links prop * test(Breadcrumbs): add unit test * test(Breadcrumbs): remove unit test * feat(Breadcrumbs): add microdata * feat(Breadcrumbs): use intl for home aria label * fix(Breadcrumbs): itemProp without wrapping with span * refactor(Breadcrumbs): modularize Breadcrumb and refine logic * style(Breadcrumbs): rename other to props * fix(Breadcrumbs): move name to link * fix(Breadcrumbs): disable microdata for truncated item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )