Feat/week06-xml-advanced #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kez-lab
reviewed
Jun 9, 2024
Comment on lines
23
to
26
| _binding = FragmentFollowerBinding.inflate(inflater, container, false) | ||
| return binding.root | ||
| return _binding?.root | ||
| } | ||
|
|
Comment on lines
47
to
49
| super.onDestroyView() | ||
| _binding?.rvFollower?.adapter = null | ||
| _binding = null |
There was a problem hiding this comment.
followerAdapter 를 메모리 해제처리 해줘야합니다
즉 lateinit var로 선언하면 불가능해지겠죠?
Comment on lines
+24
to
+25
| return _binding?.root | ||
| } |
There was a problem hiding this comment.
Suggested change
| return _binding?.root | |
| } | |
| return binding.root | |
| } |
Comment on lines
46
to
48
| super.onDestroyView() | ||
| _binding?.rvRepo?.adapter = null | ||
| _binding = null |
There was a problem hiding this comment.
여기도 _binding?.rvRepo?.adapter = null는 의미 없습니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
구현 화면
이전과 동일합니다.