Kempe standoff #34

MDKempe · 2023-12-27T20:49:28Z

No description provided.

pre-commit hooks

overall major reworking of the standoff calculations. Too many things to list.

Just added in a print statement to indicate the humidity was finished calculating.

Just a bunch of updates to make it into the tool I want.

I updated it to have a theoretical measured set of module data.

Just small formating issues here.

Major revision underway. I have most of the program working but the last few sections are still needing a bit of work.

Lots of reworking on the code to get it to have more methods for calculations. there is still a lot to be done.

martin-springer · 2024-01-03T19:17:18Z

@MDKempe - Do you know what causes the tests to fail?

Put in defaults in get_NSRDB

just working on it

Put in code to start a get_satellite function

typos fixed

fixed now.

Hopefully now it is patched correctly.

now it could work.

fixed import nsrdbx as f

MDKempe · 2024-01-03T23:40:31Z

I'm still working on this a bit. I need to do a conference call with someone to figure it out.

updated

update

Updated the demo module data to be calculated from the cell temperature instead of the module surface temperature.

Updated the manufactured module data.

Incldues the modeled POA data from Python and an updated module temperature calculation.

I changed it to instead of just having 180 degrees south be the default azimuth, it will point north or 0 degrees by default in the southern hemisphere.

It's a complete overhaul. I'm going to merge it now, but I would like it put in the main as is and to have it's name changed to "Standoff.ipynb"

Making the default azimuth be equatorial facing instead of always south. No northern-centric bias here. ;)

I fixed the cell temperature calculation to default to a wind speed factor of 1.7 instead of 1 and to allow that to be passed in. My guess is that this change will cause problems elsewhere.

Massive changes here but for the most part it is all about the standoff calculation which is working. One change to be aware of is that the prior calculations were using the module surface temperature for the standoff calculation but now it is using the cell temperature calculation.

Added in a field for wind height data to the demonstration weather data.

Added in some if/then statements to put in a field for the wind speed measurement height. For the NSRDB it is set for 2m, for PVGIS it is set for 10m.

Made it so it would delete the message indicating that Rh was being calculated once it is completed.

Created a print statement method to output the results of the standoff calculation.

Changed it to do a wind speed factor calculation based on the wind height in the meta data and the supplied power factor using appropriate defaults.

Got it to correctly use the wind speed exponent.

Fixing wind speed stuff

Modified the fatigue calculator to work with the new wind speed exponent method.

Fixed this procedure to call the module temperature function correctly.

It now uses the desired power factor for wind speed height adjustment.

It now has a field for the wind speed height.

It now uses the desired power factor for wind speed height adjustment.

It now uses the desired power factor for wind speed height adjustment. I found an error in the standoff calculation. It was previously using the module surface temperature and it should be using the module cell temperature. It makes the required standoff calculations a bit higher.

martin-springer · 2024-01-30T18:26:05Z

closing - PR got replaced with #43

martin-springer and others added 10 commits December 7, 2023 11:01

Merge pull request #33 from NREL/development

7f12df3

pre-commit hooks

Reworking of the standoff calculations

277eda3

overall major reworking of the standoff calculations. Too many things to list.

standard updates

a90a16d

Update weather.py

8343bec

Just added in a print statement to indicate the humidity was finished calculating.

updates to the standoff calculation

eda68d2

Just a bunch of updates to make it into the tool I want.

Update xeff_demo.csv

ffb6186

I updated it to have a theoretical measured set of module data.

Update standards.py

9a98da7

Just small formating issues here.

Create xeff_demo.xlsx

c3730e3

Adding calculations to the file

20bac61

Major revision underway. I have most of the program working but the last few sections are still needing a bit of work.

Update 4 - Standards.py

079e21e

Lots of reworking on the code to get it to have more methods for calculations. there is still a lot to be done.

martin-springer changed the base branch from main to development January 3, 2024 19:16

MDKempe added 9 commits January 3, 2024 14:04

Update weather.py

37882ba

Put in defaults in get_NSRDB

Update standards.py

b10d37e

just working on it

Update weather.py

1837f73

Put in code to start a get_satellite function

Update weather.py

2e109f0

typos fixed

Update weather.py

bb4f736

fixed now.

Update weather.py

d51294e

Hopefully now it is patched correctly.

Update weather.py

b1238c5

now it could work.

Update weather.py

f065a7f

Update weather.py

c876f31

fixed import nsrdbx as f

MDKempe and others added 8 commits January 4, 2024 10:28

Update weather.py

45b1a34

updated

Update 4 - Standards.ipynb

be70174

update

standards

734e0d6

Update xeff_demo.csv

f61e03b

Updated the demo module data to be calculated from the cell temperature instead of the module surface temperature.

Update xeff_demo.xlsx

8e0568a

Update xeff_demo.csv

81db018

Updated the manufactured module data.

Update xeff_demo.xlsx

d12300e

Incldues the modeled POA data from Python and an updated module temperature calculation.

Update utilities.py

a547b2f

I changed it to instead of just having 180 degrees south be the default azimuth, it will point north or 0 degrees by default in the southern hemisphere.

Kempe and others added 25 commits January 11, 2024 10:23

Massive changes and a stopping point

48e5632

It's a complete overhaul. I'm going to merge it now, but I would like it put in the main as is and to have it's name changed to "Standoff.ipynb"

Update spectral.py

0b9d138

Making the default azimuth be equatorial facing instead of always south. No northern-centric bias here. ;)

Update temperature.py

7b310b6

I fixed the cell temperature calculation to default to a wind speed factor of 1.7 instead of 1 and to allow that to be passed in. My guess is that this change will cause problems elsewhere.

improvement on temperature windspeedfactor fix

828b945

dding pytest coverage instructions

3e09f23

Wind height added

4ce8040

Added in a field for wind height data to the demonstration weather data.

Update weather.py

d44698d

Added in some if/then statements to put in a field for the wind speed measurement height. For the NSRDB it is set for 2m, for PVGIS it is set for 10m.

Update weather.py

5895169

Made it so it would delete the message indicating that Rh was being calculated once it is completed.

Update standards.py

28afc77

Created a print statement method to output the results of the standoff calculation.

Update temperature.py

0eed5f0

Changed it to do a wind speed factor calculation based on the wind height in the meta data and the supplied power factor using appropriate defaults.

Update temperature.py

bb66e97

Got it to correctly use the wind speed exponent.

Update standards.py

233452f

Got it to correctly use the wind speed exponent.

Update 4 - Standards.ipynb

bc382d3

Got it to correctly use the wind speed exponent.

Update temperature.py

0a9a3a0

Fixing wind speed stuff

Update 4 - Standards.ipynb

8e27de0

Fixing wind speed stuff

Update fatigue.py

906a1b6

Modified the fatigue calculator to work with the new wind speed exponent method.

Update test_fatigue.py

b1c6ab6

Fixed this procedure to call the module temperature function correctly.

Update humidity.py

e2fa285

It now uses the desired power factor for wind speed height adjustment.

Update h5_pytest.h5

4860938

It now uses the desired power factor for wind speed height adjustment.

Update meta.json

35cfc0e

It now has a field for the wind speed height.

Update test_humidity.py

c97ff12

It now uses the desired power factor for wind speed height adjustment.

Update test_standards.py

24afef1

It now uses the desired power factor for wind speed height adjustment.

Update test_temperature.py

b1b2083

It now uses the desired power factor for wind speed height adjustment.

martin-springer closed this Jan 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kempe standoff #34

Kempe standoff #34

MDKempe commented Dec 27, 2023

martin-springer commented Jan 3, 2024

MDKempe commented Jan 3, 2024

martin-springer commented Jan 30, 2024

Kempe standoff #34

Kempe standoff #34

Conversation

MDKempe commented Dec 27, 2023

martin-springer commented Jan 3, 2024

MDKempe commented Jan 3, 2024

martin-springer commented Jan 30, 2024