New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add detector type to config so we can use it in calibration #6

Open

CJ-Wright wants to merge 1 commit into master from det_name

Contributor

CJ-Wright commented Apr 18, 2019

@tacaswell Does this look ok? (Can a Signal return a string? I ask because I think you were the one who suggested the pixel size config)


          add detector type to config so we can use it in calibration

d431b1e

jklynch commented Jul 9, 2019

@tacaswell can you ok this as requested above?

Contributor Author

CJ-Wright commented Jul 9, 2019

This should also be done for the other detectors as well.

mrakitin approved these changes

View reviewed changes

Member

mrakitin left a comment

It can probably benefit from knowing the versions of the drivers as well, as it's done at QAS: https://github.com/NSLS-II-QAS/profile_collection/blob/35f0b006d058a17080f990cb33e5db0881886c59/startup/80-areadetector.py#L50-L52.

Member

mrakitin commented Jul 9, 2019

What are "the other detectors"?

Contributor Author

CJ-Wright commented Jul 9, 2019 •

edited

Loading

Dexela, the pilatus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet