Humble #6
Open
Humble #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix spawner tests timeout (#1692) (cherry picked from commit 079392b) # Conflicts: # controller_manager/test/test_spawner_unspawner.cpp * Fix merge conflicts --------- Co-authored-by: Sai Kishor Kothakota <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]>
…#1661) (#1695) * Refactor spawner to be able to reuse code for ros2controlcli (#1661) (cherry picked from commit 0631e3e) # Conflicts: # controller_manager/controller_manager/spawner.py # controller_manager/test/test_spawner_unspawner.cpp * [Humble] Fix conflicts of 1661 backport (#1735) * Fix conflicts * added controller_type parameter setting to the spawner --------- Co-authored-by: Sai Kishor Kothakota <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]>
…robot_description through topic (backport #1451) (#1599) * Add resources_lock_ lock_guards to avoid race condition when loading robot_description through topic (#1451) (cherry picked from commit 25f2c97) # Conflicts: # hardware_interface/src/resource_manager.cpp * Try fixing conflict. --------- Co-authored-by: Sai Kishor Kothakota <[email protected]> Co-authored-by: Dr. Denis <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]>
… utils (#1505) (#1792) (cherry picked from commit fc25478) Co-authored-by: Sai Kishor Kothakota <[email protected]>
…#1783) Co-authored-by: Sai Kishor Kothakota <[email protected]>
…ontroller (#1794) (#1797) (cherry picked from commit 0ba1428) Co-authored-by: Santosh Govindaraj <[email protected]>
* Fix timeout value in std output (#1807) We were using the wrong timeout in the terminal output there. (cherry picked from commit cb91599) # Conflicts: # controller_manager/controller_manager/controller_manager_services.py * Update controller_manager_services.py --------- Co-authored-by: Felix Exner (fexner) <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]>
* Add few warning compiler options to error (#1181) * add conversion, unused-but-set-variable, and return-type warnings to error * add shadow variables to error and their fixes for code compilation * apply the same flags to controller interface package * apply the same flags and their fixes to hardware_interface package * apply the same compiler options to the rest of the packages * Deactivate compiler warning for class_loader --------- Co-authored-by: Sai Kishor Kothakota <[email protected]> Co-authored-by: Christoph Froehlich <[email protected]>
(cherry picked from commit 86dd7d2) Co-authored-by: Christoph Fröhlich <[email protected]>
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Co-authored-by: christophfroehlich <[email protected]> (cherry picked from commit 0be4374) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
#1842) Co-authored-by: Sai Kishor Kothakota <[email protected]>
…sts (#1754) (#1838) Co-authored-by: Santosh Govindaraj <[email protected]>
…les (#1724) (#1835) Co-authored-by: Sai Kishor Kothakota <[email protected]>
* Fix Hardware spawner and add tests for it (#1759) * Tests for hardware spawner. * Fully support spawning a list of hardware components * Use python3 coverage instead of ros2 run in tests * Actually check component's state after changing it * Update hardware_spawner's user documentation --------- Co-authored-by: Dr. Denis Štogl <[email protected]> Co-authored-by: Bence Magyar <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]> (cherry picked from commit 5dbd6d5) # Conflicts: # controller_manager/CMakeLists.txt * Fix conflicts * FIx missing lines * Fix the missing bcolors.ENDC in hardware_spawner log prints (#1870) * Fix pre-commit * Fix the API of the tests and the CMakeLists.txt * Apply target properties as other tests --------- Co-authored-by: Felix Exner (fexner) <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]> Co-authored-by: Christoph Froehlich <[email protected]>
(cherry picked from commit 30d51cd) Co-authored-by: Christoph Fröhlich <[email protected]>
(cherry picked from commit bab2d30) Co-authored-by: Christoph Fröhlich <[email protected]>
Co-authored-by: Christoph Fröhlich <[email protected]>
Co-authored-by: christophfroehlich <[email protected]> (cherry picked from commit dd84414) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
… (backport #1805) (#1894) --------- Co-authored-by: Sai Kishor Kothakota <[email protected]>
--------- Signed-off-by: Angsa Deployment Team <[email protected]> Signed-off-by: Tony Najjar <[email protected]> Co-authored-by: Tony Najjar <[email protected]> Co-authored-by: Angsa Deployment Team <[email protected]>
…#1953) Co-authored-by: Sai Kishor Kothakota <[email protected]>
#1941) (#1968) --------- Co-authored-by: Sai Kishor Kothakota <[email protected]>
(cherry picked from commit 52a2ffd) Co-authored-by: Sudip Roy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.