Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] 各年度ごとに取得するように修正 #687

Merged
merged 2 commits into from
Mar 6, 2024
Merged

[fix] 各年度ごとに取得するように修正 #687

merged 2 commits into from
Mar 6, 2024

Conversation

TkymHrt
Copy link
Collaborator

@TkymHrt TkymHrt commented Feb 27, 2024 •
edited
Loading

対応Issue

resolve #677

概要

協賛活動一覧ページにおいて、選択した年度のデータのみを取得するように修正。

画面スクリーンショット等

FireShot Capture 164 - 協賛活動一覧 - localhost
FireShot Capture 166 - 協賛活動一覧 - localhost

↓ 24/03/05 New 「CSSを修正」

FireShot Capture 171 - 協賛活動一覧 - localhost

テスト項目

備考

@github-actions github-actions bot added the bug Something isn't working label Feb 27, 2024
@TkymHrt TkymHrt self-assigned this Feb 27, 2024
@Kubosaka Kubosaka requested a review from hikahana March 4, 2024 01:22
hikahana
hikahana reviewed Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@hikahana hikahana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

KazumaSun
KazumaSun reviewed Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@KazumaSun KazumaSun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作大丈夫です。
ただPRの画像にもある通り、データが存在しないときの「データがありません」の表記がテーブルの中心ではないため、表示位置を調整してもらえると、よりきれいに見えると思います。

KazumaSun
KazumaSun approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@KazumaSun KazumaSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです

@Kubosaka Kubosaka merged commit afee1bc into develop Mar 6, 2024
2 checks passed
@Kubosaka Kubosaka deleted the fix/yama/677-year-switching-function branch March 6, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikahana hikahana hikahana left review comments

@KazumaSun KazumaSun KazumaSun approved these changes

Assignees

@TkymHrt TkymHrt

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

協賛活動ページの年度切り替え
4 participants
@TkymHrt @KazumaSun @hikahana @Kubosaka