Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

既存コンポーネントをStorybook上に表示する(/purchaseorders) #817

Merged

Conversation

Ryotakobayash
Copy link
Collaborator

対応Issue

resolve #803

概要

既存のコンポーネントに対応した.stories.tsxファイルを作成する。

  • DeleteModal.stories.tsx
  • DetailModal.stories.tsx
  • EditModal.stories.tsx
  • OpenAddModalButton.stories.tsx
  • OpenDeleteModalButton.stories.tsx
  • OpenEditModalButton.stories.tsx
  • PurchaseltemNumModal.stories.tsx
  • PurchaseOrderAddModal.stories.tsx

あとFinanSu/view/next-project/src/storiesの中を階層構造にするためにmain.tsをちょっと編集しました。

画面スクリーンショット等

image

テスト項目

  • Storybookを起動してスクリーンショットのようなカタログが表示されるか

備考

このブランチがmergeされるとstoriesファイルの中を階層構造にできるようになる…はず…

Copy link
Collaborator

@Kubosaka Kubosaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

少しコメントしましたー

createdAt: new Date().toISOString(), // 現在の日付のISO文字列
deadline: new Date().toISOString(), // 現在の日付のISO文字列
},
purchaseItem: [], // 購入項目の配列、必要に応じて詳細を追加
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

てきとうでいいので、購入物品も追加してもらっていいですか?

{    id: 1,
    item: 'ノートパソコン',
    price: '100000',
    quantity: 2,
    detail: 'ビジネス用',
    url: 'http://example.com',
    finance_check: false,
}

expenses: [
{
id: '123',
name: 'オフィス用品',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expensesは支出元なのでnameを〇〇局にして欲しいです

…of github.com:NUTFes/FinanSu into feat/kobayashi/CreatingstoriesFile/purchaseorders-803
@Kubosaka Kubosaka requested review from Kubosaka July 5, 2024 10:05
Copy link
Collaborator

@Kubosaka Kubosaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kubosaka Kubosaka merged commit 32da5bb into develop Jul 5, 2024
2 checks passed
@Kubosaka Kubosaka deleted the feat/kobayashi/CreatingstoriesFile/purchaseorders-803 branch July 5, 2024 10:06
@Ryotakobayash Ryotakobayash restored the feat/kobayashi/CreatingstoriesFile/purchaseorders-803 branch July 27, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

既存コンポーネントをStorybook上に表示する(/purchaseorders)
2 participants