Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

報告未登録の申請取得APIの作成 #824

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

Kubosaka
Copy link
Collaborator

@Kubosaka Kubosaka commented Jul 4, 2024

resolve #822

概要

  • 購入報告に登録されていない購入申請のdetailsを取得するAPIを作成
  • swaggerへの追加
  • フロントのパス修正

画面スクリーンショット等

スクリーンショット 2024-07-04 13 52 13

テスト項目

  • swaggerを立ち上げ、/purchaseorders/details/unregistered/:yearの確認
  • フロントの購入報告ページ→購入申請から登録→未登録のデータのみ表示されているか確認
  • コードレビュー

備考

@Kubosaka Kubosaka requested review from KazumaSun and hikahana July 4, 2024 04:54
@Kubosaka Kubosaka self-assigned this Jul 4, 2024
Copy link
Collaborator

@KazumaSun KazumaSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作は大丈夫でした。
気になるところとして、カードが横いっぱいまで表示されるため、横幅を少し狭めるとよいと思います。

スクリーンショット 2024-07-06 143606

@Kubosaka Kubosaka requested a review from KazumaSun July 8, 2024 02:46
@Kubosaka Kubosaka merged commit 187b565 into develop Jul 15, 2024
2 checks passed
@Kubosaka Kubosaka deleted the feat/kubosaka/822-get-unrigstered-order-api branch July 15, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants