Feat/uchida/832 modal tap off screen #834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubosaka
reviewed
Jul 8, 2024
Comment on lines
+354
to
+357
| const closeModal = () => { | ||
| props.setIsOpen(false); | ||
| }; | ||
|
|
There was a problem hiding this comment.
関数が広い行数にかかって書いてあるととっ散らかって可読性が下がるので、
213行目とかに移動してもらっていいですか
(このコンポーネント自体のコード自体すごく汚くて申し訳ありません)
Comment on lines
+428
to
+430
| const closeModal = () => { | ||
| props.setIsOpen(false); | ||
| }; |
| @@ -24,7 +24,7 @@ const SponsorDeleteModal: FC<ModalProps> = (props) => { | |||
| }; | |||
|
|
|||
| return ( | |||
| <Modal className='md:w-1/2'> | |||
| <Modal className='md:w-1/2' onClick={() => props.setShowModal(false)}> | |||
| <div className='w-full'> | |||
| <div className='ml-auto w-fit'> | |||
| <CloseButton onClick={() => props.setShowModal(false)} /> | |||
There was a problem hiding this comment.
ここも同じ処理をしているので関数にまとめてもらっていいですか？
const closeModal = () => {
props.setIsOpen(false);
};
| return ( | ||
| <Modal className='md:w-1/2'> | ||
| <Modal className='md:w-1/2' onClick={closeModal}> | ||
| <div className='w-full'> | ||
| <div className='ml-auto mr-5 w-fit'> | ||
| <CloseButton onClick={() => props.setIsOpen(false)} /> |
There was a problem hiding this comment.
46行目も処理同じなのでonClick={closeModal}にしてください！
| return ( | ||
| <Modal className='md:w-1/2'> | ||
| <Modal className='md:w-1/2' onClick={closeModal}> | ||
| <div className='w-full'> | ||
| <div className='ml-auto mr-5 w-fit'> | ||
| <CloseButton onClick={() => props.setIsOpen(false)} /> |
There was a problem hiding this comment.
Suggested change
| <CloseButton onClick={() => props.setIsOpen(false)} /> | |
| <CloseButton onClick={closeModal}> |
Comment on lines
+27
to
30
| <Modal className='md:w-1/2' onClick={() => props.setShowModal(false)}> | ||
| <div className='w-full'> | ||
| <div className='ml-auto w-fit'> | ||
| <CloseButton onClick={() => props.setShowModal(false)} /> |
There was a problem hiding this comment.
ここもどこかでcloseModal関数を定義して、まとめてもらっていいですか？
const closeModal = () => {
props.setIsOpen(false);
};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
協賛企業のモーダルをクリックで閉じるようにする #832
resolve #832
概要
ページでモーダルを閉じるときに✖︎ボタンを押さないと閉じれないから、モーダル外を押すと閉じるようにする
画面スクリーンショット等
URLスクリーンショット
テスト項目
備考