Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

学内募金の登録・編集時に登録済の教員を選択できないようにする #838

Merged
merged 4 commits into from
Jul 10, 2024
Merged

学内募金の登録・編集時に登録済の教員を選択できないようにする #838

merged 4 commits into from
Jul 10, 2024

Conversation

Kubosaka
Copy link
Collaborator

@Kubosaka Kubosaka commented Jul 8, 2024 •
edited
Loading

resolve #837

概要

  • 登録済教員のid配列をAPIで取得し、学内募金の登録、編集時に選択不可にした
  • 軽微なリファクタリング

画面スクリーンショット等

  • URL
    スクリーンショット
    スクリーンショット 2024-07-10 21 17 30

テスト項目

  • 募金の登録、編集を触って動作がおかしくないか検証する
  • 登録済教員が選択不可になっているか

備考

@github-actions github-actions bot added the enhancement New feature or request label Jul 8, 2024
@Kubosaka Kubosaka added frontend and removed enhancement New feature or request labels Jul 8, 2024
@Kubosaka Kubosaka self-assigned this Jul 10, 2024
hikahana
hikahana approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@hikahana hikahana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image
編集開いたとき上記画像のようになります。
名称として、「募金の編集」「編集する」になった方が適切な気がします。
とりあえずこのPRはokなのでapproveします

@Kubosaka Kubosaka merged commit e6aa0e4 into develop Jul 10, 2024
2 checks passed
@Kubosaka Kubosaka deleted the feature/kubosaka/837-no-select-teachers branch July 10, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikahana hikahana hikahana approved these changes

Assignees

@Kubosaka Kubosaka

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

募金登録済みの教員を選択不可にする
2 participants
@Kubosaka @hikahana