Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

請求書の編集機能の追加 #869

Merged
merged 4 commits into from
Aug 11, 2024

Conversation

Kubosaka
Copy link
Collaborator

resolve #868

概要

  • 請求書でスタイルや担当者名などを発行前に編集できるようにした
  • 新しく請求書用の型を作った

画面スクリーンショット等

  • URL
スクリーンショット 2024-08-11 2 35 52

テスト項目

  • 請求書の発行に問題がないか
  • 正しく請求書を編集できるか
  • エラーが起きないか

備考

@Kubosaka Kubosaka requested a review from TkymHrt August 10, 2024 17:39
@Kubosaka Kubosaka self-assigned this Aug 10, 2024
Copy link
Collaborator

@TkymHrt TkymHrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

正しく請求書の発行ができました!
値段のフォームだけ問題ありそうだったのでコメントしています。

value={invoiceSponsorStyle.price}
onChange={(e) => {
onChangeSponsorStyle(
{ ...invoiceSponsorStyle, price: Number(e.target.value) },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

値段に誤って全角文字を入力すると、NaN表示になり修正が不可能になる問題があります。

Suggested change
{ ...invoiceSponsorStyle, price: Number(e.target.value) },
{
...invoiceSponsorStyle,
price: isNaN(Number(e.target.value))
? invoiceSponsorStyle.price
: Number(e.target.value),
},

Copy link
Collaborator Author

@Kubosaka Kubosaka Aug 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。
修正しました。
全角の対応

@TkymHrt TkymHrt self-requested a review August 11, 2024 07:18
Copy link
Collaborator

@TkymHrt TkymHrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kubosaka Kubosaka merged commit 34bad9d into develop Aug 11, 2024
2 checks passed
@Kubosaka Kubosaka deleted the feat/kubosaka/868-edit-invoice-modal branch August 11, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

協賛活動の請求書で任意のフォームで編集できるようにする
2 participants