Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

予算管理ページの作成(フロント) #894

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

TkymHrt
Copy link
Collaborator

@TkymHrt TkymHrt commented Nov 24, 2024

対応Issue

resolve #893

概要

予算管理ページの作成を行いました。見た目だけです。
登録モーダルボタンやCSV出力ボタンは飾りです。
現在モックデータを参照しているので、API実装時に差し替えが必要です。

画面スクリーンショット等

image
image
image
image

テスト項目

  • 予算管理ページ(http://localhost:3000/budget_managements)にアクセスできる。
  • 局・部門・物品の表示が選択毎に行われる。

@TkymHrt TkymHrt self-assigned this Nov 24, 2024
@TkymHrt TkymHrt requested a review from Copilot November 24, 2024 11:50

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

view/next-project/src/components/common/OutlinePrimaryButton/OutlinePrimaryButton.tsx:12

  • There is an extra space at the beginning of the class name string concatenation. It should be removed to avoid potential issues with class names.
'flex justify-center px-4 py-2 text-primary-1 font-bold text-md rounded-lg bg-white-0 border border-primary-1 hover:bg-white-100 hover:text-primary-2 hover:border-primary-2' +
@TkymHrt TkymHrt requested a review from Copilot December 2, 2024 15:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 suggestion.

}`}
onClick={() => handleRowClick(item)}
>
<div className='flex justify-center gap-2 py-3'>
Copy link
Preview

Copilot AI Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Div elements are not valid children of tr elements. This should be replaced with a valid table structure.

Suggested change
<div className='flex justify-center gap-2 py-3'>
<td className='flex justify-center gap-2 py-3'>

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@TkymHrt TkymHrt requested a review from Copilot December 2, 2024 15:29
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 suggestion.

Comments skipped due to low confidence (1)

view/next-project/src/components/common/OutlinePrimaryButton/OutlinePrimaryButton.tsx:12

  • [nitpick] Consider using template literals for better readability in className concatenation.
'flex justify-center px-4 py-2 text-primary-1 font-bold text-md rounded-lg bg-white-0 border border-primary-1 hover:bg-white-100 hover:text-primary-2 hover:border-primary-2' +

);
}, [selectedDivisionId]);

let displayItems: any[] = [];
Copy link
Preview

Copilot AI Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of 'any' type for 'displayItems' can lead to potential type safety issues. Consider using a more specific type.

Suggested change
let displayItems: any[] = [];
let displayItems: (Department | Division | Item)[] = [];

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@TkymHrt TkymHrt requested a review from Copilot December 3, 2024 09:27

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • view/next-project/package-lock.json: Language not supported
  • view/next-project/package.json: Language not supported
  • view/next-project/src/pages/_app.tsx: Evaluated as low risk
Comments skipped due to low confidence (1)

view/next-project/src/components/budget_managements/BudgetManagement.tsx:49

  • The variable 'displayItems' is typed as 'any[]'. This should be changed to a more specific type once the API is implemented.
let displayItems: any[] = [];
@TkymHrt TkymHrt marked this pull request as ready for review December 11, 2024 12:18
@TkymHrt TkymHrt changed the title 【WIP】予算管理ページの作成(フロント) 予算管理ページの作成(フロント) Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

予算管理ページの作成(フロント)
1 participant