-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apiテスト導入 #897
Open
Kubosaka
wants to merge
7
commits into
develop
Choose a base branch
from
feat/kubosaka/intro-test
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
apiテスト導入 #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubosaka
commented
Dec 12, 2024
@@ -0,0 +1,12 @@ | |||
use finansu_test_db; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODOこんな感じてテストDBもテーブル作る
hikahana
reviewed
Dec 14, 2024
以下のようになるんですけどここはどうする系ですか。
|
@hikahana |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
画面スクリーンショット等
URL
スクリーンショット
テスト項目
make run-test
でテストが実行できるか確認する備考
This pull request includes several changes to enhance the Go project, including updates to the project dependencies, improvements to the server initialization, and the addition of new test fixtures and test cases. The most important changes are summarized below:
Dependencies and Configuration:
api/go.mod
to ensure compatibility and include new packages..vscode/settings.json
to use thegolang.go
formatter.Server Initialization and Testing:
func RunServer
inapi/drivers/server/server.go
to return an*echo.Echo
instance, facilitating better testability. [1] [2]func InitializeServer
inapi/internals/di/di.go
to return bothdb.Client
and*echo.Echo
, and added a newInitializeTestServer
function for setting up the test environment. [1] [2]api/test/fixtures/users.yml
and comprehensive test cases inapi/test/sample_test.go
to ensure robust testing of the API endpoints. [1] [2]Database and Docker:
Minor Code Improvements:
These changes collectively improve the project's structure, testability, and maintainability.