Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

テストデプロイ時に出たエラー #310

Merged
merged 9 commits into from
Sep 9, 2024

Conversation

hikahana
Copy link
Collaborator

@hikahana hikahana commented Sep 9, 2024

対応Issue

  • resolve #0

概要

実装詳細

画面スクリーンショット等

テスト項目

  • [ ]
  • [ ]
  • [ ]

備考

@github-actions github-actions bot added frontend bug Something isn't working labels Sep 9, 2024
Copy link
Collaborator

@TkymHrt TkymHrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codegenしたら差分出てきたんですが正常ですか?エラーもたくさん

image image

あと、view-userのNumberCardLarge.tsxですが、オプショナルチェーン (?.)のつけ忘れ見つけました。番号がない状態でエラーになります。

import React from "react";
import styles from "./NumberCardLarge.module.css";
import { SubscribeListNumbersSubscription } from "@/type/graphql";

interface NumberCardLargeProps {
  bingoNumber?: SubscribeListNumbersSubscription["numbers"][number];
}

const NumberCardLarge = (props: NumberCardLargeProps) => {
  return (
    <div className={styles.container}>
      <div className={styles.number}>{props.bingoNumber?.number}</div>
    </div>
  );
};

export default NumberCardLarge;

@hikahana
Copy link
Collaborator Author

hikahana commented Sep 9, 2024

左の画像はnameをユニークにしてたからマージの時に消えてた。
右の画像はenvのendpointタイポかminioにしてないからだと思われです

@hikahana hikahana requested a review from TkymHrt September 9, 2024 15:33
Copy link
Collaborator

@TkymHrt TkymHrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hikahana hikahana merged commit ab5cadb into develop Sep 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants