Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic for strict check of the parameters of nested dataclasses #24

Merged
merged 28 commits into from
May 7, 2024

Conversation

Kipok
Copy link
Collaborator

@Kipok Kipok commented May 7, 2024

Somehow by default omegaconf ignores any extra parameters, e.g. if I add ++test=1 and test is not a supported parameter in a dataclass, it does not cause any issues (the code executes as if I didn't specify test). This can lead to potentially costly errors, when you have a typo in some parameter name and the default value is used instead. The logic in this PR ensures that any non-supported parameters will raise an error in our code.

Kipok added 28 commits May 1, 2024 16:17
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
@Kipok Kipok merged commit fc0a19a into main May 7, 2024
6 checks passed
@Kipok Kipok deleted the igitman/unused-pm-errors branch May 7, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant