-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing the necessity of prompt details in data preparation #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we think here, we can add a warning (not error) that prompt_config and prompt_template are missing if they are not provided, can make it better if people might forget?
Sure thing, let me add that! |
Added the suggestions made and fixed tests. Let me know if anything else needs to be done. |
Signed-off-by: Igor Gitman <[email protected]>
The current data preparation config requires prompt details to be specified.
However, there are times when we're dealing with data prepared for SFT, such as when we're downsampling the data.
This PR adds support for such cases.