Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large refactoring, many new features, lots of changes #34

Merged
merged 123 commits into from
Jun 7, 2024

Conversation

Kipok
Copy link
Collaborator

@Kipok Kipok commented Jun 6, 2024

Sorry for the huge PR.. Will merge without review since changes are too large - we can fix things in follow ups.

Main things that have changed are the following:

  1. A lot of refactoring on core classes. Now the server code is fully isolated and can be used with a straightforward interface and no code execution if that's not required (see inference docs).
  2. Support for retrieval-based prompts and associated refactoring on the prompt class.
  3. Trtllm server is completely new and ~2x faster.
  4. A lot of new tests, most of which are not run in CI, but can be triggered locally (see tests/gpu-tests/run.sh)
  5. Direct support for nemotron chat format for both inference and training
  6. Support for multinode servers
  7. Some renaming for various flags / scripts to better align with new code structure
  8. Some improvements on math evaluation
  9. All packages are upgraded to latest versions

Some known broken things:

  1. Documentation with --help
  2. OpenAI model
  3. Data explorer tool

Kipok added 30 commits May 3, 2024 11:47
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Kipok and others added 28 commits June 4, 2024 23:16
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
@Kipok Kipok merged commit b8cb9ae into main Jun 7, 2024
6 checks passed
@Kipok Kipok deleted the igitman/retrieval-to-merge branch June 7, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants