Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default min length #1935

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix default min length #1935

wants to merge 1 commit into from

Conversation

akhoroshev
Copy link
Contributor

@akhoroshev akhoroshev commented Jul 11, 2024 •
edited
Loading

When passing 1 to the minimum length I expect at least 1 NOT eof token.

But since 1 is the default value minLengths tensor is nullptr and penalty does't work.

@akhoroshev
Copy link
Contributor Author

@nv-guomingz

@nv-guomingz
Copy link
Collaborator

@nv-guomingz

Thanks for your patience, We'll start integration and verification soon.

@akhoroshev
Copy link
Contributor Author

@nv-guomingz ping :)

@hchings hchings added triaged Issue has been triaged by maintainers labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
triaged Issue has been triaged by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akhoroshev @nv-guomingz @hchings