Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/incorrect lora out dims #2484

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bugfix/incorrect lora out dims #2484

wants to merge 2 commits into from

Conversation

akhoroshev
Copy link
Contributor

@akhoroshev akhoroshev commented Nov 22, 2024 •
edited
Loading

I have in-house model for which hidden_size != num_heads * head_size (attention dimension is higher then hidden_size) and lora doesn't work properly. But after this fix, everything works exactly the same as in Python (same generations).

My target modules:

  "target_modules": [
    "v_proj",
    "q_proj",
    "k_proj",
    "down_proj"
  ],

It probably makes sense to make similar changes for kCROSS_ATTN_Q,kCROSS_ATTN_V,kCROSS_ATTN_K

@hello-11 hello-11 added the triaged Issue has been triaged by maintainers label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
triaged Issue has been triaged by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akhoroshev @hello-11