DRAFT : Reservation with groups new #214
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinivas212
requested review from
amaslenn,
TaekyungHeo and
srivatsankrishnan
jeffnvidia
changed the title
jeffnvidia
force-pushed
the
reservation_with_groups_new
branch
2 times, most recently
from
19672ec
to
5fcd477
Compare
jeffnvidia
force-pushed
the
reservation_with_groups_new
branch
from
5fcd477
to
5c84eaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##Summary
This PR is intended to enable reservation with group node selection (previously, reservation only worked when specifying node names)
This PR is based on this one which cleaned the slurm_system file : #167
##Test Plan
Tested with
extra_srun_args = "--reservation reservation_name" in system.toml
test scenario :
name = "gpt_175B"
[Tests]
[Tests.1]
name = "gpt_175B"
nodes = ['cluster:SU2:2', 'cluster:SU3:3', 'cluster:SU4:3']
$ python ./cloudaix.py --mode run --system-config ... --test-templates-dir conf/v0.6/general/test_template --tests-dir conf/v0.6/general/test --test-scenario conf/v0.6/general/test_scenario/gpt/gpt_175B.toml
...
Section Name: Tests.1
Test Name: gpt_175B
Description: gpt
No dependencies
[INFO] Initializing Runner
[INFO] Creating SlurmRunner
[INFO] Starting test scenario execution.
[INFO] Starting test: Tests.1
[INFO] Running test: Tests.1