-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NeMo 2.0 support #293
NeMo 2.0 support #293
Conversation
9349a3f
to
f07e0f1
Compare
e3ca13b
to
68025cc
Compare
a2e30ee
to
15b2e87
Compare
src/cloudai/schema/test_template/nemo_run/slurm_command_gen_strategy.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a new case into test_acceptance
.
src/cloudai/schema/test_template/nemo_run/report_generation_strategy.py
Outdated
Show resolved
Hide resolved
src/cloudai/schema/test_template/nemo_run/slurm_command_gen_strategy.py
Outdated
Show resolved
Hide resolved
Design Discussion (Nov 18th, 2024)
|
src/cloudai/schema/test_template/nemo_run/slurm_command_gen_strategy.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the conversation in the last call, the direct executor method of directly calling the srun without sbatch
is what we are calling as Nemo2.0 support.
-
Can we ensure this works with test hooks? (@TaekyungHeo If I recall, you mentioned this should be simpler in Nemo 2.0 integration with CloudIAI), if yes, as part of calling Nemo2.0 support complete, can we have an example configurations that is also tested with test hooks? Could be a different PR but I feel it should be there.
-
If direct executor is going to be generic feature in Nemo 2.0, can we test it with other models to ensure this simpler interface holds true across different models. Zsolt seems to be running more complex models via Nemo 2.0. Can we keep these models in the radar and ensure this approach works for those models as well?
((If I recall both @TaekyungHeo and @amaslenn mentioned they are okay with this PR as is and any future PR should address it.)
So I will approve this PR but those ^ should be added to call Nemo 2.0 support complete IMO.
cc: @srinivas212
Thanks, @srivatsankrishnan.
|
Summary
This PR introduces support for NeMo 2.0 in CloudAI. Initially, we planned to dump fiddle configurations to a file and load them in NeMo-Run. However, I changed the approach to use NeMo-Run directly to execute a model. Marc Romejin informed me that we can run a task with a recipe without generating an sbatch script, known as a "direct executor" in NeMo-Run. To run NeMo 2.0, you can use the following command:
Test Plan