Add tooling to bump golang version #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
tariq1890
reviewed
Jul 17, 2024
| @@ -36,7 +36,7 @@ jobs: | |||
| - name: Get Golang version | |||
| id: vars | |||
| run: | | |||
| GOLANG_VERSION=$( grep "GOLANG_VERSION :=" versions.mk ) | |||
| GOLANG_VERSION=$(./hack/golang-version.sh) | |||
There was a problem hiding this comment.
nit: I've never quite understood the convention behind naming the scripts directory hack. I assume that it is a practice popularised by the k8s community.
I've always preferred scripts as it's more intuitive to the reader
There was a problem hiding this comment.
I think one could argue that scripts are for external consumption whereas hack is for internal consumption.
And yes, this seems to be a k8s convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.