Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cudf submodule sync #2629

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Fix cudf submodule sync #2629

merged 2 commits into from
Nov 27, 2024

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Nov 26, 2024

rapidsai/cudf#17427 where nvtx/ranges.hpp was being implicitly included from another header where it was removed, so updated the source to include this directly.
This also updates to breaking changes in rapidsai/rmm#1722 where we need to explicitly link against rmm's logger impl to restore logging functionality.

@jlowe jlowe added the build label Nov 26, 2024
@jlowe jlowe self-assigned this Nov 26, 2024
@jlowe
Copy link
Member Author

jlowe commented Nov 26, 2024

build

Copy link
Collaborator

@pxLi pxLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pxLi pxLi merged commit 4d5b51d into NVIDIA:branch-25.02 Nov 27, 2024
5 checks passed
@jlowe jlowe deleted the fix-sync branch November 27, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants